On 02/05/20 01:22, Ard Biesheuvel wrote: > On Wed, 29 Jan 2020 at 21:44, Laszlo Ersek <ler...@redhat.com> wrote: >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 >> Repo: https://github.com/lersek/edk2.git >> Branch: smram_at_default_smbase_bz_1512_wave_1_v2 >> Supersedes: <20190924113505.27272-1-ler...@redhat.com> >> >> V1 is archived at: >> - http://mid.mail-archive.com/20190924113505.27272-1-lersek@redhat.com >> - https://edk2.groups.io/g/devel/message/47924 >> >> Igor's patch set, mentioned in the v1 blurb, has been merged into QEMU >> meanwhile. The relevant QEMU commit is f404220e279c ("q35: implement >> 128K SMRAM at default SMBASE address", 2020-01-22). >> >> In v2: >> - trim the Cc list >> >> - pick up Jiewen's R-b for patches #1 through #9, from: >> - >> http://mid.mail-archive.com/74D8A39837DF1E4DA445A8C0B3885C503F7CBCB2@shsmsx102.ccr.corp.intel.com >> - https://edk2.groups.io/g/devel/message/48166 >> >> - add patch #10, and update patch #11, for satisfying Jiewen's condition >> on his R-b. >> >> Cc: Anthony Perard <anthony.per...@citrix.com> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Cc: Jiewen Yao <jiewen....@intel.com> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Julien Grall <jul...@xen.org> >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (11): >> OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase >> OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro >> defs >> OvmfPkg/IndustryStandard: add MCH_DEFAULT_SMBASE* register macros >> OvmfPkg/PlatformPei: factor out Q35BoardVerification() >> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (skeleton) >> OvmfPkg/PlatformPei: assert there's no permanent PEI RAM at default >> SMBASE >> OvmfPkg/PlatformPei: reserve the SMRAM at the default SMBASE, if it >> exists >> OvmfPkg/SEV: don't manage the lifecycle of the SMRAM at the default >> SMBASE >> OvmfPkg/SmmAccess: close and lock SMRAM at default SMBASE >> OvmfPkg: introduce PcdCsmEnable feature flag >> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real) >> > > For the series, > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
Much appreciated! Pushed via <https://github.com/tianocore/edk2/pull/332>, commit range 422da35375c6..75839f977d37. Laszlo > > >> OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 106 >> +++++++++++--------- >> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +++- >> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4 + >> OvmfPkg/OvmfPkg.dec | 11 ++ >> OvmfPkg/OvmfPkgIa32.dsc | 4 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 4 + >> OvmfPkg/OvmfPkgX64.dsc | 4 + >> OvmfPkg/OvmfXen.dsc | 3 + >> OvmfPkg/PlatformPei/AmdSev.c | 24 ++++- >> OvmfPkg/PlatformPei/MemDetect.c | 94 >> ++++++++++++++--- >> OvmfPkg/PlatformPei/Platform.c | 24 +++++ >> OvmfPkg/PlatformPei/Platform.h | 7 ++ >> OvmfPkg/PlatformPei/PlatformPei.inf | 2 + >> OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 7 ++ >> OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 1 + >> OvmfPkg/SmmAccess/SmmAccessPei.c | 6 ++ >> OvmfPkg/SmmAccess/SmmAccessPei.inf | 1 + >> OvmfPkg/SmmAccess/SmramInternal.c | 25 +++++ >> OvmfPkg/SmmAccess/SmramInternal.h | 8 ++ >> 19 files changed, 285 insertions(+), 71 deletions(-) >> >> -- >> 2.19.1.3.g30247aa5d201 >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53823): https://edk2.groups.io/g/devel/message/53823 Mute This Topic: https://groups.io/mt/70252369/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
