> >
> > 2 minor comments:
> > 1. StartPciRootPortsOnBridge()
> >      Can it be renamed to EnablePciDevicesOnBridge()?
> >      Because it basically calls PciIo.Attribute() to enable the devices. 
> > And I am
> not
> > sure the enable only applies to PCI root ports. There could be PCI devices
> behind
> > P2P bridge.
> It enables only Type 1 PCI devices (Root Port, PCIe-to-PCI Bridge, PCIe switch
> upstream/downstream ports), and no endpoint (Type 0) devices.

I see. Then how about EnablePciBridges()?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52391): https://edk2.groups.io/g/devel/message/52391
Mute This Topic: https://groups.io/mt/55155883/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to