On Tue, 19 Nov 2019 at 13:44, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Tue, Nov 19, 2019 at 01:16:28PM +0100, Philippe Mathieu-Daudé wrote: > > > As per Leif's comments in > > > https://www.mail-archive.com/devel@edk2.groups.io/msg05292.html: > > > > > > "I don't want patches submitted with anyone other than the > > > contributor's Signed-off-by" > > > > I missed this thread, now I'm slightly confused. > > > > Checking the Wiki: > > > > https://github.com/tianocore/edk2/blob/master/Readme.md#code-contributions > > > > and: > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Signature-Format#signed-off-by > > > > Signed-off-by > > > > Authors should use Signed-off-by (See example below) > > If you've received the code from a trusted source, and are > > forwarding it along, please add a Signed-off-by line for > > yourself to indicate that you know this code to be usable > > by our community. > > > > The guideline is simply "add a S-o-b", but Leif says "[only?] > > No. > Whoever contributes the patch must add an S-o-b. > And contracts are signed in one's own name. > > This is not a TianoCore twitch, this is the fundamental way in which > DCO works in all projects that use it - including linux and QEMU. > > https://wiki.qemu.org/Contribute/SubmitAPatch: > * You must provide a Signed-off-by: line (this is a hard requirement > because it's how you say "I'm legally okay to contribute this and > happy for it to go into QEMU" > which is based on > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.4-rc8#n418 > > The confusing bit I find here is in > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line > with its statement of "but again, that author's Signed-off-by: line is > mandatory,", in direct conflict with the text at the top of the page > *if* the patch was not one already contributed to QEMU. >
The point is really that you should not add a s-o-b line just to credit authorship. The s-o-b indicates that the person in question asserts that the contribution is compatible with the project's license policies. The author may not even be aware that the code is being contributed to a certain project, and so adding a s-o-b on their behalf in this case should be avoided. TL;DR: SOB != authorship It might make sense to permit an Author: or Authored-by: tag to make this distinction more explicit. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50899): https://edk2.groups.io/g/devel/message/50899 Mute This Topic: https://groups.io/mt/60553574/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
