On 2019.11.19 12:02, Philippe Mathieu-Daudé wrote:
On 11/19/19 12:38 PM, Pete Batard wrote:
From: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>

Add a missing entry for the "Raspberry Pi Compute Module 3+" in
RpiFirmwareGetModelName ().

Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>

I feel really lost with how the S-o-b are handled.

If you look at the thread, you'll see that Leif provided a patch (he basically split a patch from the existing), which he signed of.

I therefore included it as is. Hence the S-o-b being Leif here.

But yeah, I agree this whole business is confusing.

Regards,

/Pete


I'd have expected, Samer as the author, signs it. Pete forwards it, then Leif refactors a bit by extracting a part of the previous bigger patch.
So:

Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>
Signed-off-by: Pete Batard <p...@akeo.ie>
Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>

Anyway, back to the technical content:
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>

---
  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
index 9b4aa068857c..dcb434fabefe 100644
--- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
+++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
@@ -1,5 +1,6 @@
  /** @file
   *
+ *  Copyright (c) 2019, ARM Limited. All rights reserved.
   *  Copyright (c) 2017-2018, Andrei Warkentin <andrey.warken...@gmail.com>
   *  Copyright (c) 2016, Linaro, Ltd. All rights reserved.
   *
@@ -595,6 +596,8 @@ RpiFirmwareGetModelName (
      return "Raspberry Pi 3 Model B+";
    case 0x0E:
      return "Raspberry Pi 3 Model A+";
+  case 0x10:
+    return "Raspberry Pi Compute Module 3+";
    case 0x11:
      return "Raspberry Pi 4 Model B";
    default:




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50895): https://edk2.groups.io/g/devel/message/50895
Mute This Topic: https://groups.io/mt/60553572/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to