On Thu, Nov 14, 2019 at 04:07:35PM +0000, Pete Batard wrote:
> Bcm2711 is the SoC used by the Raspberry Pi 4. For the most part it
> is backward compatible with the Bcm283x SoC used by older models but
> some new Bcm2711 registers have been introduced such as the ones for
> PCIe.
>
> We therefore introduce a new Bcm27xx module, which contains only the
> base address for the new registers for now (set from a PCD as is the
> case for Bcm283x) but which should get populated further as we add
> support for the Raspberry Pi 4.
>
> Signed-off-by: Pete Batard <p...@akeo.ie>
> ---
> Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 22
> ++++++++++++++++++++
> Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 15
> +++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec
> b/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec
> new file mode 100644
> index 000000000000..815302f6d209
> --- /dev/null
> +++ b/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec
> @@ -0,0 +1,22 @@
> +## @file
> +#
> +# Copyright (c) 2019, Pete Batard <p...@akeo.ie>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + DEC_SPECIFICATION = 0x0001001A
> + PACKAGE_NAME = Bcm27xxPkg
> + PACKAGE_GUID = D4B585C5-EBCA-4779-B974-05A3CF2F10C4
> + PACKAGE_VERSION = 1.0
> +
> +[Includes]
> + Include
> +
> +[Guids]
> + gBcm27xxTokenSpaceGuid = {0x44045e56, 0x7056, 0x4be6, {0x88, 0xc0, 0x49,
> 0x0c, 0x67, 0x90, 0x2f, 0xba}}
> +
> +[PcdsFixedAtBuild.common]
> + gBcm27xxTokenSpaceGuid.PcdBcm27xxRegistersAddress|0x0|UINT32|0x00000001
> diff --git a/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h
> b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h
> new file mode 100644
> index 000000000000..389667714214
> --- /dev/null
> +++ b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h
> @@ -0,0 +1,15 @@
> +/** @file
> + *
> + * Copyright (c) 2019, Pete Batard <p...@akeo.ie>.
> + *
> + * SPDX-License-Identifier: BSD-2-Clause-Patent
> + *
> + **/
> +
> +#ifndef __BCM2711_H__
> +#define __BCM2711_H__
Nit: Could you drop leading __ for macros?
With that:
Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
/
Leif
> +
> +#define BCM2711_SOC_REGISTERS (FixedPcdGet64
> (PcdBcm27xxRegistersAddress))
> +#define BCM2711_SOC_REGISTER_LENGTH 0x02000000
> +
> +#endif /*__BCM2711_H__ */
> --
> 2.21.0.windows.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50837): https://edk2.groups.io/g/devel/message/50837
Mute This Topic: https://groups.io/mt/57792551/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
