On Thu, 19 Sep 2019 at 12:52, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Thu, Sep 19, 2019 at 12:38:00PM +0300, Ard Biesheuvel wrote: > > On Wed, 18 Sep 2019 at 15:27, Baptiste Gerondeau > > <baptiste.gerond...@linaro.org> wrote: > > > > > > From: Baptiste GERONDEAU <bgerond...@gmail.com> > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750"; > > > > > > Since RVCT shares the same assembler syntax as MSFT, use .asm files > > > and associate them with MSFT, which would be a first step to addressing > > > the above Bugzilla issue. > > > RVCT will also have to be erased from BaseTools/rest of the build > > > infrastructure, to fully address BZ#1750 ; this patch only addresses the > > > "code" in itself. > > > > > > Signed-off-by: Baptiste Gerondeau <baptiste.gerond...@linaro.org> > > > > The changes look fine to me, but please split them out per package as > > Liming suggested. > > Hmm, and I've just gone and contradicted that. > As I said in my reply to Liming, this is a very special situation, and > the net effect of splitting this patch up is that we end up with a > set of not-usefully-bisectable patches. >
Fair enough. I won't get involved in that discussion, though. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47584): https://edk2.groups.io/g/devel/message/47584 Mute This Topic: https://groups.io/mt/34187300/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
