Reviewed-by: Dandan Bi <dandan...@intel.com> Thanks, Dandan > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 18, 2019 3:49 AM > To: edk2-devel-groups-io <devel@edk2.groups.io> > Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Wu, Hao A <hao.a...@intel.com>; Wang, Jian J <jian.j.w...@intel.com> > Subject: [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in > place of EFI_HII_HANDLE > > HiiGetHiiHandles() returns an array of EFI_HII_HANDLEs, not EFI_HANDLEs. > HiiGetString() takes an EFI_HII_HANDLE, not an EFI_HANDLE. > > This change is a no-op in practice; it's a semantic improvement. > > Cc: Dandan Bi <dandan...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > lightly tested, as UefiHiiLib is used by both ArmVirt and OVMF > > MdeModulePkg/Library/UefiHiiLib/HiiString.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiString.c > b/MdeModulePkg/Library/UefiHiiLib/HiiString.c > index 498f245dce1f..95229f8a8c9f 100644 > --- a/MdeModulePkg/Library/UefiHiiLib/HiiString.c > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiString.c > @@ -173,8 +173,8 @@ HiiGetPackageString ( > IN CONST CHAR8 *Language OPTIONAL > ) > { > - EFI_HANDLE *HiiHandleBuffer; > - EFI_HANDLE HiiHandle; > + EFI_HII_HANDLE *HiiHandleBuffer; > + EFI_HII_HANDLE HiiHandle; > > ASSERT (PackageListGuid != NULL); > > -- > 2.19.1.3.g30247aa5d201 >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47515): https://edk2.groups.io/g/devel/message/47515 Mute This Topic: https://groups.io/mt/34180208/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
