Reviewed-by: Ray Ni <ray...@intel.com>
> -----Original Message-----
> From: Laszlo Ersek <ler...@redhat.com>
> Sent: Tuesday, September 17, 2019 12:49 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Andrew Fish <af...@apple.com>; Justen, Jordan L
> <jordan.l.jus...@intel.com>; Ni, Ray <ray...@intel.com>
> Subject: [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke
> notify registration
>
> EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require
> the notification handle to have type (VOID*). The notification handle has
> nothing to do with the EFI_HANDLE type.
>
> This change is a semantic fix; functionally, it's a no-op.
>
> Cc: Andrew Fish <af...@apple.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Ray Ni <ray...@intel.com>
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> ---
>
> Notes:
> build-tested only
>
> EmulatorPkg/EmuGopDxe/GopInput.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c
> b/EmulatorPkg/EmuGopDxe/GopInput.c
> index fdd0b4911555..2a23564a2173 100644
> --- a/EmulatorPkg/EmuGopDxe/GopInput.c
> +++ b/EmulatorPkg/EmuGopDxe/GopInput.c
> @@ -517,7 +517,7 @@ EmuGopSimpleTextInExRegisterKeyNotify (
> IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This,
> IN EFI_KEY_DATA *KeyData,
> IN EFI_KEY_NOTIFY_FUNCTION KeyNotificationFunction,
> - OUT EFI_HANDLE *NotifyHandle
> + OUT VOID **NotifyHandle
> )
> {
> EFI_STATUS Status;
> @@ -600,7 +600,7 @@ EFI_STATUS
> EFIAPI
> EmuGopSimpleTextInExUnregisterKeyNotify (
> IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This,
> - IN EFI_HANDLE NotificationHandle
> + IN VOID *NotificationHandle
> )
> /*++
>
> --
> 2.19.1.3.g30247aa5d201
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47423): https://edk2.groups.io/g/devel/message/47423
Mute This Topic: https://groups.io/mt/34180205/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
