On Mon, Sep 16, 2019 at 05:31:40AM +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Thursday, September 5, 2019 4:40 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > <abner.ch...@hpe.com> > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 04/22]: > > MdePkg/Include: RISC-V definitions. > > > > On Wed, Sep 04, 2019 at 06:42:59PM +0800, Abner Chang wrote: > > > Add RISC-V processor related definitions. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > > > --- > > > MdePkg/Include/IndustryStandard/PeImage.h | 14 +- > > > MdePkg/Include/Library/BaseLib.h | 67 ++++++ > > > MdePkg/Include/Protocol/DebugSupport.h | 55 +++++ > > > MdePkg/Include/Protocol/PxeBaseCode.h | 8 + > > > MdePkg/Include/RiscV64/ProcessorBind.h | 336 > > ++++++++++++++++++++++++++++++ > > > MdePkg/Include/Uefi/UefiBaseType.h | 25 +++ > > > MdePkg/Include/Uefi/UefiSpec.h | 11 + > > > 7 files changed, 513 insertions(+), 3 deletions(-) create mode > > > 100644 MdePkg/Include/RiscV64/ProcessorBind.h > > > > > > diff --git a/MdePkg/Include/IndustryStandard/PeImage.h > > > b/MdePkg/Include/IndustryStandard/PeImage.h > > > index 720bb08..47796b2 100644 > > > --- a/MdePkg/Include/IndustryStandard/PeImage.h > > > +++ b/MdePkg/Include/IndustryStandard/PeImage.h > > > @@ -9,6 +9,8 @@ > > > > > > Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.<BR> Portions copyright (c) 2008 - 2009, Apple Inc. All > > > rights reserved.<BR> > > > +Portions Copyright (c) 2016, Hewlett Packard Enterprise Development > > > +LP. All rights reserved.<BR> > > > + > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -34,6 +36,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #define IMAGE_FILE_MACHINE_X64 0x8664 > > > #define IMAGE_FILE_MACHINE_ARMTHUMB_MIXED 0x01c2 > > > #define IMAGE_FILE_MACHINE_ARM64 0xAA64 > > > +#define IMAGE_FILE_MACHINE_RISCV32 0x5032 > > > +#define IMAGE_FILE_MACHINE_RISCV64 0x5064 > > > +#define IMAGE_FILE_MACHINE_RISCV128 0x5128 > > > > > > // > > > // EXE file formats > > > @@ -478,9 +483,9 @@ typedef struct { > > > /// > > > #define EFI_IMAGE_SIZEOF_BASE_RELOCATION 8 > > > > > > -// > > > -// Based relocation types. > > > -// > > > +/// > > > +/// Based relocation types. > > > +/// > > > > I don't know if this change to the comment block is a wonky rebase or > > whatever, but please drop it. > > No, I revised it to three back slash because most of comment block > use three back slash.
It is always appreciated when people provide style fixes, but they should be provided as separate patches. In this case I don't see the value in doing that however, since // is the comment format specified by the coding standars. A separate patch fixing the existing incorrect ones would be preferable (but not important). Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47372): https://edk2.groups.io/g/devel/message/47372 Mute This Topic: https://groups.io/mt/33137122/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
