On Wed, Sep 04, 2019 at 06:43:05PM +0800, Abner Chang wrote: > Support RISC-V cache related functions. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > --- > .../BaseSynchronizationLib.inf | 6 + > .../RiscV64/Synchronization.c | 189 > +++++++++++++++++++++ > .../RiscV64/SynchronizationAsm.s | 84 +++++++++
Shouldn't this be SynchronizationAsm.S? Or well, "Asm" shouldn't be in the name, the filename ending takes care of dscribing what type of file it is. But .s (lowercase) denotes an assembler file that is *not* run through the C preprocessor, which ... I really don't see the point of. The filename should always be *.S (so we don't need to go back and rename the files if we decide to add include statements or local #defines). / Leif > 3 files changed, 279 insertions(+) > create mode 100644 > MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.c > create mode 100644 > MdePkg/Library/BaseSynchronizationLib/RiscV64/SynchronizationAsm.s -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46908): https://edk2.groups.io/g/devel/message/46908 Mute This Topic: https://groups.io/mt/33137133/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-