Reviewed-by: Michael Kubacki <michael.a.kuba...@intel.com> > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, September 11, 2019 9:40 AM > To: devel@edk2.groups.io > Cc: phi...@redhat.com; Agyeman, Prince <prince.agye...@intel.com>; > Wei, David Y <david.y....@intel.com>; Gao, Liming <liming....@intel.com>; > Sinha, Ankit <ankit.si...@intel.com>; Kubacki, Michael A > <michael.a.kuba...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com> > Subject: [edk2-devel] [PATCH v2 2/3] SimicsOpenBoardPkg: Fix GCC build > issues > > From: "Agyeman, Prince" <prince.agye...@intel.com> > > Removed unused functions in secMain.c > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162 > > Cc: David Wei <david.y....@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Ankit Sinha <ankit.si...@intel.com> > Cc: Agyeman Prince <prince.agye...@intel.com> > Cc: Kubacki Michael A <michael.a.kuba...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Signed-off-by: Prince Agyeman <prince.agye...@intel.com> > --- > .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- > .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- > 2 files changed, 61 deletions(-) > > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > index 117c72b35f..953a4a6c15 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > @@ -316,12 +316,6 @@ ConnectRootBridge ( > IN VOID *Context > ); > > -STATIC > -VOID > -SaveS3BootScript ( > - VOID > - ); > - > // > // BDS Platform Functions > // > @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( > PciAcpiInitialization (); > } > > -/** > - Save the S3 boot script. > - > - Note that DxeSmmReadyToLock must be signaled after this function > returns; > - otherwise the script wouldn't be saved actually. > -**/ > -STATIC > -VOID > -SaveS3BootScript ( > - VOID > - ) > -{ > - EFI_STATUS Status; > - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; > - STATIC CONST UINT8 Info[] = { 0xDE, 0xAD, 0xBE, 0xEF }; > - > - Status = gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, > - (VOID **) &BootScript); > - ASSERT_EFI_ERROR (Status); > - > - // > - // Despite the opcode documentation in the PI spec, the protocol > - // implementation embeds a deep copy of the info in the boot script, > rather > - // than storing just a pointer to runtime or NVS storage. > - // > - Status = BootScript->Write(BootScript, > EFI_BOOT_SCRIPT_INFORMATION_OPCODE, > - (UINT32) sizeof Info, > - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); > - ASSERT_EFI_ERROR (Status); > -} > - > - > /** > Do the platform specific action after the console is ready > > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > index 5cbb47687b..4514641b46 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( > return EFI_SUCCESS; > } > > - > -/** > - Reads 8-bits of CMOS data. > - > - Reads the 8-bits of CMOS data at the location specified by Index. > - The 8-bit read value is returned. > - > - @param Index The CMOS location to read. > - > - @return The value read. > - > -**/ > -STATIC > -UINT8 > -CmosRead8 ( > - IN UINTN Index > - ) > -{ > - IoWrite8 (0x70, (UINT8) Index); > - return IoRead8 (0x71); > -} > - > - > STATIC > BOOLEAN > IsS3Resume ( > -- > 2.19.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47140): https://edk2.groups.io/g/devel/message/47140 Mute This Topic: https://groups.io/mt/34105604/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
