On 08/29/19 11:49, Leif Lindholm wrote: > On Wed, Aug 28, 2019 at 05:33:28PM +0000, Ni, Ray wrote:
>> With the existence of mail attachments capability in new groups.io >> system, can we accept such kind of patch submission? Or any side >> effect you see if allowing mail attachments? > > Traditionally, the reason for not wanting patches as attachments is > that it complicates doing inline code review as part of the email. > > If the mail system (let's take a wild guess, Outlook/Exchange?) > doesn't corrupt the text *too* badly, I don't have an issue with the > patch being sent in the message body *and* being attached so it could > actually be applied. > > Alternatively, one could put the patch in the message body and a link > to the patch in a public repo where it can be obtained. I agree (with either alterative), as follows: - The patch must be pasted manually in the message body, or it must be attached. - The patch must be published in a personal git repo, and the email posting needs to reference that repo / branch. - This is only acceptable as an exception to the workflow, and not as the norm. (As long as our official contribution workflow is mailing list based.) - Doesn't work for patch series, only for single patches. - v2, v3 and so iterations must use separate topic branches in the submitter's personal repository. Non-fast-forward pushes to already posted -- hence publicly referenced -- branches are not acceptable. Effectively, once v(n) is posted, the submitter should consider the matching topic branch in their own repo read-only. - The edk2 package maintainer that ends up pushing the patch is responsible for ensuring that the patch taken with "git fetch" for integration is identical to the patch that was manually pasted by the submitter. The idea is that mailing list based review work as always, plus that the patch that goes in ultimately be the same patch that got reviewed on the list. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46569): https://edk2.groups.io/g/devel/message/46569 Mute This Topic: https://groups.io/mt/33041050/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
