Ping again. Thanks, Zhichao
> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Friday, July 26, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > oleks...@ami.com > Subject: FW: [edk2-devel] [PATCH V2] > ShellPkg/UefiShellDriver1CommandsLib: Make array big enough > > Ping. Please help to review it. > > Thanks, > Zhichao > > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Monday, July 22, 2019 2:58 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > Oleksiy <oleks...@ami.com> > Subject: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: > Make array big enough > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1941 > > The two CHAR16 array ChildCountStr and DeviceCountStr is defined to hold > the decimal string data of UINTN. The max of UINTN is > 18446744073709551615 and it contain 20 characters. > So make their size to 21 CHAR16s to hold the string data with a null- > terminate. > UnicodeValueToStringS regard the value input as INT64, and > 21 CHARs is enough to hold the lowest value with minus '-'. > Although the value shouldn't be such big. > > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Oleksiy <oleks...@ami.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > > V2: > Update the copyright. > > ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > index 794b737bd1..27cd278cf0 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > @@ -2,7 +2,7 @@ > Main file for Drivers shell Driver1 function. > > (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR> > - Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2010 - 2019, Intel Corporation. All rights > + reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -263,8 +263,8 @@ ShellCommandRunDrivers ( > EFI_HANDLE *HandleWalker; > UINTN ChildCount; > UINTN DeviceCount; > - CHAR16 ChildCountStr[3]; > - CHAR16 DeviceCountStr[3]; > + CHAR16 ChildCountStr[21]; > + CHAR16 DeviceCountStr[21]; > CHAR16 *Temp2; > CONST CHAR16 *FullDriverName; > CHAR16 *TruncatedDriverName; > -- > 2.21.0.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45596): https://edk2.groups.io/g/devel/message/45596 Mute This Topic: https://groups.io/mt/32861764/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
