On 7/30/19 4:01 PM, Leif Lindholm wrote:
> On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote:
>> Hi,
>>
>> This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg:
>> DebugPeCoffExtraActionLib: debugger commands are not errors", from
>> 2015-03-02), on PeCoffLoaderUnloadImageExtraAction().
>>
>> This solves an issue when building in silent mode with
>> -D DEBUG_PRINT_ERROR_LEVEL=0x80000000. With the QemuRamFbDxe platform
>> DXE driver, when we get a driver dispatch failure it is reported as
>> an error level:
>>
>> qemu-system-aarch64 -machine virt,gic-version=3,accel=kvm -cpu host \
>> -display none -serial stdio -bios /usr/share/AAVMF/AAVMF_CODE.fd
>> remove-symbol-file
>> /builddir/build/BUILD/edk2-89910a39dcfd/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/OvmfPkg/QemuRamfbDxe/QemuRamfbDxe/DEBUG/QemuRamfbDxe.dll
>> 0x3F5F6000
>>
>> The second patch is an obvious typo fix.
>
> I added the word "comment" in subject/message of 2/2, to make
> it explicit that the typo does not affect functionality.
Good idea, thanks.
>
> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
> Pushed as 8fed4e47d9a6..3d34b5f32692.
Thanks Laszlo and Leif!
>
> Thanks!
>
>> Regards,
>>
>> Phil.
>>
>> Philippe Mathieu-Daudé (2):
>> ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors
>> ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos
>>
>> .../DebugPeCoffExtraActionLib.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> --
>> 2.20.1
>>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44631): https://edk2.groups.io/g/devel/message/44631
Mute This Topic: https://groups.io/mt/32645506/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
