On 07/29/19 20:03, Philippe Mathieu-Daude wrote:
> In commit 1fce963d89f3e we reduced the level of information printed
> by PeCoffLoaderRelocateImageExtraAction() but we did not update the
> similar PeCoffLoaderUnloadImageExtraAction() function.
>
> PeCoffLoaderUnloadImageExtraAction() prints helpful debugger commands
> for source level debugging. These messages should not be printed on the
> EFI_D_ERROR level; they don't report errors. Change the debug level
> (bitmask, actually) to DEBUG_LOAD | DEBUG_INFO, because the messages are
> printed in relation to image loading, and they are informative.
>
> Cc: Leif Lindholm <leif.lindh...@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Reported-by: Andrew Jones <drjo...@redhat.com>
> Suggested-by: Laszlo Ersek <ler...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
> ---
> .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> index a1cb99677fe6..3379744aa185 100644
> --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> @@ -122,14 +122,14 @@ PeCoffLoaderUnloadImageExtraAction (
> if (ImageContext->PdbPointer) {
> #ifdef __CC_ARM
> // Print out the command for the RVD debugger to load symbols for this
> image
> - DEBUG ((EFI_D_ERROR, "unload symbols_only %a\n", DeCygwinPathIfNeeded
> (ImageContext->PdbPointer, Temp, sizeof (Temp))));
> + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "unload symbols_only %a\n",
> DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp))));
> #elif __GNUC__
> // This may not work correctly if you generate PE/COFF directlyas then
> the Offset would not be required
> - DEBUG ((EFI_D_ERROR, "remove-symbol-file %a 0x%08x\n",
> DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)),
> (UINTN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders)));
> + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "remove-symbol-file %a 0x%08x\n",
> DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)),
> (UINTN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders)));
> #else
> - DEBUG ((EFI_D_ERROR, "Unloading %a\n", ImageContext->PdbPointer));
> + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading %a\n",
> ImageContext->PdbPointer));
> #endif
> } else {
> - DEBUG ((EFI_D_ERROR, "Unloading driver at 0x%11p\n", (VOID *)(UINTN)
> ImageContext->ImageAddress));
> + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading driver at 0x%11p\n", (VOID
> *)(UINTN) ImageContext->ImageAddress));
> }
> }
>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44625): https://edk2.groups.io/g/devel/message/44625
Mute This Topic: https://groups.io/mt/32645507/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
