Mike: OK. If so, the consumer code also need to obviously include vendor header file, such as #include <Register/Intel/Cpuid.h>. Right?
Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, July 30, 2019 11:42 AM > To: Gao, Liming <[email protected]>; Ni, Ray <[email protected]>; > [email protected]; Kinney, Michael D > <[email protected]> > Cc: Dong, Eric <[email protected]>; Laszlo Ersek <[email protected]> > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to > MdePkg > > Liming, > > There is an unresolved discussion on the location of this > file in the MdePkg. I prefer a vendor name in the path. > > MdePkg/Include/Register/Intel/Cpuid.h > > Also, after this file is moved to MdePkg, we can enter > new BZs to update all the modules that call AsmCpuid and > AsmCpuidEx to use the defines and structures from Cpuid.h. > > Mike > > > -----Original Message----- > > From: Gao, Liming > > Sent: Monday, July 29, 2019 8:29 PM > > To: Ni, Ray <[email protected]>; [email protected] > > Cc: Kinney, Michael D <[email protected]>; > > Dong, Eric <[email protected]>; Laszlo Ersek > > <[email protected]> > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h from UefiCpuPkg to MdePkg > > > > The change is good to me. Reviewed-by: Liming Gao > > <[email protected]> > > > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Wednesday, July 24, 2019 6:00 PM > > > To: [email protected] > > > Cc: Kinney, Michael D <[email protected]>; > > Gao, Liming > > > <[email protected]>; Dong, Eric > > <[email protected]>; Laszlo Ersek > > > <[email protected]> > > > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h > > from UefiCpuPkg > > > to MdePkg > > > > > > REF: > > https://bugzilla.tianocore.org/show_bug.cgi?id=2008 > > > > > > MdeModulePkg/DxeIpl needs to get CPUID output for CPU > > 5-level paging > > > capability detection. > > > > > > In order to use the macros/structures defined in > > > UefiCpuPkg/Include/Register/Cpuid.h, the patch moves > > Cpuid.h to > > > MdePkg/Include/Register/ directory. > > > > > > Because almost every module depends on MdePkg.dec in > > its INF file, the > > > move almost has no impact. > > > > > > Signed-off-by: Ray Ni <[email protected]> > > > Cc: Michael D Kinney <[email protected]> > > > Cc: Liming Gao <[email protected]> > > > Cc: Eric Dong <[email protected]> > > > Cc: Laszlo Ersek <[email protected]> > > > --- > > > {UefiCpuPkg => MdePkg}/Include/Register/Cpuid.h | 0 > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename {UefiCpuPkg > > > => MdePkg}/Include/Register/Cpuid.h (100%) > > > > > > diff --git a/UefiCpuPkg/Include/Register/Cpuid.h > > > b/MdePkg/Include/Register/Cpuid.h similarity index > > 100% rename from > > > UefiCpuPkg/Include/Register/Cpuid.h > > > rename to MdePkg/Include/Register/Cpuid.h > > > -- > > > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44586): https://edk2.groups.io/g/devel/message/44586 Mute This Topic: https://groups.io/mt/32582439/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
