Reviewed by Qian, Yi <[email protected]> Thanks QianYi
-----Original Message----- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: [email protected] Cc: Sun, Zailiang <[email protected]>; Qian, Yi <[email protected]> Subject: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN Change the type of the local variable Size in the function AcpiPlatformEntryPoint() from UINT32 to UINTN. This local variable is passed into the function ReadSection() that returns a value of type UINTN. Using type UINT32 can potentially corrupt an adjacent local on the stack. Cc: Zailiang Sun <[email protected]> Cc: Yi Qian <[email protected]> Signed-off-by: Michael D Kinney <[email protected]> --- Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c index 0bd375391e..5c03f66edb 100644 --- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c +++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2004 - 2019, Intel Corporation. All rights + reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -778,7 +778,7 @@ AcpiPlatformEntryPoint ( EFI_ACPI_COMMON_HEADER *CurrentTable; UINTN TableHandle; UINT32 FvStatus; - UINT32 Size; + UINTN Size; EFI_EVENT Event; EFI_ACPI_TABLE_VERSION TableVersion; UINTN VarSize; @@ -1223,7 +1223,7 @@ AcpiPlatformEntryPoint ( EFI_SECTION_RAW, Instance, (VOID **) &CurrentTable, - (UINTN *) &Size, + &Size, &FvStatus ); -- 2.21.0.windows.1 -- Qian Yi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40342): https://edk2.groups.io/g/devel/message/40342 Mute This Topic: https://groups.io/mt/31551770/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
