Comments for Laszlo's question (11). > -----Original Message----- > From: Gao, Liming > Sent: Sunday, May 5, 2019 11:22 PM > To: Laszlo Ersek <ler...@redhat.com>; devel@edk2.groups.io > Cc: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, Siyuan > <siyuan...@intel.com> > Subject: RE: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include > segment files to NetworkPkg. > > Reply for the comments in the patch content. > > -----Original Message----- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Monday, April 29, 2019 9:05 PM > > To: devel@edk2.groups.io; Gao, Liming <liming....@intel.com> > > Cc: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ting...@intel.com>; Fu, > Siyuan <siyuan...@intel.com> > > Subject: Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include > segment files to NetworkPkg. > > > > On 04/25/19 14:37, Liming Gao wrote: > > > This patch provides a set of include segment files for platform owner to > > > easily enable/disable network stack support on their platform. > > >
[...] > > > > (11) I think the following lib class resolution is missing: > > > > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > > > NetworkPkg/NetworkLibs.dsc.inc includes the network specific library > instances. > If TlsLib is designed only for network, I agree to add it. The TlsLib is a generic library not only for network stack. Only TlsAuthConfigDxe and TlsDxe in NetworkPkg are network specific. > > > > > Other than that, I agree this include file is good. The OpenSSL lib > > class resolution can depend on many factors, and the NetworkPkg aspects > > are already well explained in the DSC include file, near the > > NETWORK_TLS_ENABLE and NETWORK_ISCSI_ENABLE flags. > > > > > > > > > diff --git a/NetworkPkg/NetworkPcds.dsc.inc > b/NetworkPkg/NetworkPcds.dsc.inc > > > new file mode 100644 > > > index 0000000000..f874b382ef > > > --- /dev/null > > > +++ b/NetworkPkg/NetworkPcds.dsc.inc > > > @@ -0,0 +1,16 @@ > > > +## @file > > > +# Network DSC include file for [Pcds*] section of all Architectures. > > > +# > > > +# This file can be included to the [Pcds*] section(s) of a platform DSC > file > > > +# by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD > settings > > > +# according to the value of flags described in "NetworkDefines.dsc.inc". > > > +# > > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > > > +# > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > +# > > > +## > > > + > > > +!if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE > > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > > > +!endif > > > > > > > This file looks good. > > > > > > The "v3 2/3" patch makes me happy -- thank you for providing the include > > snippets without section headers, letting the platform provide its own > > section headers! > > > > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40058): https://edk2.groups.io/g/devel/message/40058 Mute This Topic: https://groups.io/mt/31341797/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
