>-----Original Message----- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Saturday, April 27, 2019 6:19 AM >To: Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D ><michael.d.kin...@intel.com> >Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Gao, Liming ><liming....@intel.com>; Leif Lindholm <leif.lindh...@linaro.org> >Subject: Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required >ARM library to pass ARM build > >On Sat, 27 Apr 2019 at 00:04, Laszlo Ersek <ler...@redhat.com> wrote: >> >> On 04/25/19 14:37, Liming Gao wrote: >> > Signed-off-by: Liming Gao <liming....@intel.com> >> > --- >> > NetworkPkg/NetworkPkg.dsc | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc >> > index 66d43bec12..955e45e84d 100644 >> > --- a/NetworkPkg/NetworkPkg.dsc >> > +++ b/NetworkPkg/NetworkPkg.dsc >> > @@ -55,6 +55,7 @@ >> > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf >> > >FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf >> > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> >> "MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf" seems to be >> ARM/AARCH64 only. Packages that are not inherently specific to >> ARM/AARCH64 include this library resolution only in the following sections: >> >> [LibraryClasses.ARM, LibraryClasses.AARCH64] >> >> But the above hunk, from NetworkPkg.dsc, seems to fall under >> [LibraryClasses]. I think that might break NetworkPkg.dsc builds on >> IA32/X64.
Agree. I will move it to ARM arch section. >> >> > >> > [LibraryClasses.common.UEFI_DRIVER] >> > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf >> > @@ -72,6 +73,7 @@ >> > # [LibraryClasses.ARM] and NULL mean link this library into all ARM >images. >> > # >> > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> > + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf >> > >> > [PcdsFeatureFlag] >> > gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE >> >> I'll let Ard & Leif comment on this. >> > >Sigh. > >The RNG code in OpenSSL uses a 'double' to record the current entropy >level, even though the value is in the range [0 .. 31] (IIRC). >Unfortunately, this does imply that any .DSC that incorporates TLS or >other crypto code for ARM needs this resolution to be included. > > >> >> > @@ -115,7 +117,7 @@ >> > NetworkPkg/Application/IpsecConfig/IpSecConfig.inf >> > NetworkPkg/Application/VConfig/VConfig.inf >> > >> > -[Components.IA32, Components.X64] >> > +[Components.IA32, Components.X64, Components.ARM, >Components.AARCH64] >> > NetworkPkg/IpSecDxe/IpSecDxe.inf >> > NetworkPkg/IScsiDxe/IScsiDxe.inf >> > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf >> > >> >> Shouldn't we just merge this section into [Components] above? >> >> Or are these modules unsuitable for EBC? >> > >(+ Mike) > >This came up at the plugfest: is it really necessary to keep building >arbitrary modules using EBC? EBC is no longer mandatory, and the >compiler diagnostics of the other toolchains are much better than they >were 10+ years ago. Now, those modules can't pass build on EBC, because of CryptoLib. I agree EBC compiler is too old. I agree to remove it. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39718): https://edk2.groups.io/g/devel/message/39718 Mute This Topic: https://groups.io/mt/31341793/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
