Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/463#issuecomment-162752711
@felixcheung
That code change does not make sense. It looks to me like the new code
literally **does nothing**.
If this was a version-API change, we would expect there to be code that
**detects the version** and then runs the old code if its less than 1.6, and
newer code if the version is 1.6 or greater.
The code in this PR does not do that.
You're taking something that was done on one line of code and moving it to
two. Ok, fine. Pointless, but fine.
Then you start casting collections to be Java collections - but you do it
for all versions of Spark?
This doesn't look like it has to do with an API change.
It looks like this code does nothing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
