Reamer commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1291985709
> But in the other frontend Job `run-e2e-tests-in-zeppelin-web`, I think it is inappropriate to add test dependencies in pom.xml of `zeppelin-web` , so I use `./mvnw clean package -pl zeppelin-integration -B -Pintegration -Pspark-scala-2.11 -Pspark-2.4 -Phadoop2 -DskipTests -DskipRat -am` to install as few modules as possible. > How do you think about it? You are moving in the right direction. That is exactly what I meant. You should add the `<scope>test</scope>` to your dependencies. In the end, it doesn't make any difference with this module, as it only consists of tests, but it's cleaner. The CI test `run-e2e-tests-in-zeppelin-web` builds on the sub-module `zeppelin-web`. Also in the pom.xml all dependencies for the tests should be defined. So that we only call the following commands in the workflow file. `./mvnw clean install -pl zeppelin-web -B -Pscala-2.11 -Pweb-e2e -DskipTests -DskipRat -am` and afterwards for testing `xvfb-run --auto-servernum --server-args="-screen 0 1024x768x24" ./mvnw verify -pl zeppelin-web -B -Pscala-2.11 -Pweb-e2e -DskipRat` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
