[GitHub] [zeppelin] iiiusky commented on a change in pull request #4282: [ZEPPELIN-5624] Check if the path directory is compliant.

[GitBox]

iiiusky commented on a change in pull request #4282:
URL: https://github.com/apache/zeppelin/pull/4282#discussion_r822695183



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
##########
@@ -1038,8 +1038,10 @@ private boolean inlineRemove(String id, boolean 
initiator) throws IOException {
       removed = true;
     }
 
-    File localRepoDir = new File(conf.getInterpreterLocalRepoPath() + "/" + 
id);
-    FileUtils.deleteDirectory(localRepoDir);
+    File localRepoPath = new File(conf.getInterpreterLocalRepoPath());

Review comment:
       ```
   if (interpreterSettings.containsKey(id)) {
         InterpreterSetting intp = interpreterSettings.get(id);
         intp.close();
         removeInterpreterSetting(id);
         if (initiator) {
           // Event initiator saves the file
           // Cluster event accepting nodes do not need to save files repeatedly
           saveToFile();
         }
         FileUtils.deleteDirectory(new File(localRepoPath, id));
         removed = true;
       }
   
   ```
   
   Do you mean to do it this way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org