[GitHub] [zeppelin] iiiusky commented on a change in pull request #4282: [ZEPPELIN-5624] Check if the path directory is compliant.

[GitBox]

iiiusky commented on a change in pull request #4282:
URL: https://github.com/apache/zeppelin/pull/4282#discussion_r790365745



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
##########
@@ -1035,6 +1035,9 @@ private boolean inlineRemove(String id, boolean 
initiator) throws IOException {
     }
 
     File localRepoDir = new File(conf.getInterpreterLocalRepoPath() + "/" + 
id);
+    if (localRepoDir.getAbsolutePath().contains("..")) {
+      return removed;
+    }
     FileUtils.deleteDirectory(localRepoDir);

Review comment:
       Normally it is unreasonable, maybe it can be changed to this?
   ```
    if (!localRepoDir.getAbsolutePath().contains("..")&& removed) {
         FileUtils.deleteDirectory(localRepoDir);
    }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org