zjffdu commented on a change in pull request #4299:
URL: https://github.com/apache/zeppelin/pull/4299#discussion_r816619334
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
##########
@@ -310,25 +311,40 @@ public String importNote(String sourceJson, String
notePath, AuthenticationInfo
* @throws IOException
*/
public String cloneNote(String sourceNoteId, String newNotePath,
AuthenticationInfo subject)
+ throws IOException {
+ return cloneNote(sourceNoteId, "", newNotePath, subject);
+ }
+
+
+ public String cloneNote(String sourceNoteId, String revisionId, String
newNotePath, AuthenticationInfo subject)
throws IOException {
return processNote(sourceNoteId,
sourceNote -> {
if (sourceNote == null) {
throw new IOException("Source note: " + sourceNoteId + " not found");
}
+ Note sourceNoteWithVersion;
Review comment:
Better to name it as `sourceNote`, because it may not has version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
