[GitHub] [zeppelin] Reamer commented on a change in pull request #4294: [ZEPPELIN-5644] Reduce redundancy during the interpreter execution process

[GitBox]

Reamer commented on a change in pull request #4294:
URL: https://github.com/apache/zeppelin/pull/4294#discussion_r795378350



##########
File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
##########
@@ -482,9 +490,14 @@ public void close(String sessionId, String className) 
throws InterpreterRPCExcep
           Iterator<Interpreter> it = interpreters.iterator();
           while (it.hasNext()) {
             Interpreter inp = it.next();
-            if (inp.getClassName().equals(className)) {
+            LazyOpenInterpreter lazy = (LazyOpenInterpreter) inp;

Review comment:
       Is this cast safe? I would prefer an Instanceof test before making this 
cast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org