saLeox commented on pull request #4294:
URL: https://github.com/apache/zeppelin/pull/4294#issuecomment-1025422297


   > @saLeox Thank you for your contribution. BTW, could you please add some 
tests for this feature? I think your implementation looks reasonable but it 
would be better we have tests.
   Hi @jongyoul, thanks for your reply, the modification I made are covered by 
some existing junit method, like SparkInterpreterTest.testSparkInterpreter() or 
RemoteInterpreterServerTest.testInterpreter(), should I add some specified 
cases in those methods?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to