[GitHub] [zeppelin] cuspymd commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

[GitBox]

cuspymd commented on a change in pull request #4137:
URL: https://github.com/apache/zeppelin/pull/4137#discussion_r654276703



##########
File path: 
flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java
##########
@@ -99,7 +104,7 @@ private static TableSchema removeTimeAttributes(TableSchema 
schema) {
   protected abstract String getType();
 
   public String run(String st) throws IOException {
-    Table table = stenv.sqlQuery(st);
+    this.table = stenv.sqlQuery(st);
     String tableName = "UnnamedTable_" +
             "_" + SQL_INDEX.getAndIncrement();
     return run(table, tableName);

Review comment:
       `this.table` member variable can not be set normally if `run(Table 
table, String tableName)` method be called directly.
   Is it OK in this scenario?

##########
File path: 
flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java
##########
@@ -99,7 +104,7 @@ private static TableSchema removeTimeAttributes(TableSchema 
schema) {
   protected abstract String getType();
 
   public String run(String st) throws IOException {
-    Table table = stenv.sqlQuery(st);
+    this.table = stenv.sqlQuery(st);
     String tableName = "UnnamedTable_" +
             "_" + SQL_INDEX.getAndIncrement();
     return run(table, tableName);

Review comment:
       `this.table` member variable can not be set normally if `run(Table 
table, String tableName)` method be called directly. Is it OK in this scenario?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org