[GitHub] [zeppelin] zjffdu commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

[GitBox]

zjffdu commented on a change in pull request #4137:
URL: https://github.com/apache/zeppelin/pull/4137#discussion_r651419884



##########
File path: 
flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java
##########
@@ -319,4 +319,22 @@ public Map extractTableConfigOptions() {
     }
     return configOptions;
   }
+
+  @Override
+  public String[] row2String(Object row, Object table, Object tableConfig) {
+    return rowToString((Row) row);
+  }

Review comment:
       Thanks for the review @cuspymd I have rename method name to be 
rowToString. Regarding the parameter type, it is not possible to use the 
specific type because the api inconsistent across different flink versions, so 
I have to use type Object and let each version of `FlinkShims` to do the type 
casting




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org