zjffdu commented on a change in pull request #4029:
URL: https://github.com/apache/zeppelin/pull/4029#discussion_r561988786
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -513,7 +513,7 @@ public Connection getConnection(String dbPrefix,
InterpreterContext context)
String url = properties.getProperty(URL_KEY);
String connectionUrl = appendProxyUserToURL(url, user, dbPrefix);
- String authType = properties.getProperty("zeppelin.jdbc.auth.type",
"SIMPLE")
+ String authType =
StringUtils.defaultIfEmpty(getProperty("zeppelin.jdbc.auth.type"), "SIMPLE")
Review comment:
I think it is better to not pass empty value property to interpreter
process. Could you add this line of change to this PR ? This line would filter
the empty value properties so that we wont' get empty property in interpreter
process side.
https://github.com/apache/zeppelin/compare/master...zjffdu:temp?expand=1#diff-16f9d9720acee6c9c8f2a1580099ef3499737773a2916967b05948db08148ab9R630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
