Great, that would also avoid to duplicate code between the implementations of NotebookStorage and ConfigStorage.
El jue., 4 oct. 2018 a las 19:00, Jeff Zhang (<[email protected]>) escribió: > Right, this is the future plan. I plan to unify both config stuff and > notebookrepo. > So that all the configuration files and notebook files will be stored in > the same storage layer. > > > Jhon Anderson Cardenas Diaz <[email protected]>于2018年10月5日周五 > 上午6:21写道： > > > Also maybe the *helium configuration* should be included in the > > ConfigStorage component, in order to be persisted like others > > configurations. > > > > El jue., 4 oct. 2018 a las 16:44, Jhon Anderson Cardenas Diaz (< > > [email protected]>) escribió: > > > > > Hi! > > > > > > Currently in the ConfigStorage component there are methods to persist > and > > > retrieve the credentials of the zeppelin users: > > > > > > public abstract String loadCredentials() throws IOException; > > > public abstract void saveCredentials(String credentials) throws > > > IOException; > > > > > > But those methods are not being used by the Credentials component. > > > Credentials component is always persisting the information in a file > > (which > > > can be encrypted). > > > > > > Do you guys know what is the future plan for Credentials component?, > will > > > it use ConfigStorage at some point or will those methods be removed > from > > > ConfigStorage component? > > > > > > Thank you. > > > > > >
