GitHub user weand opened a pull request:
https://github.com/apache/zeppelin/pull/3202
[ZEPPELIN-3528] [branch-0.8] Ordering by interpreter name in same
interpreter group
### What is this PR for?
Merge for branch-0.8.
In 'Create new note' diagram, 'Default Interpreter' is ordered by only
interpreter groups.
But interpreter is not ordered in same interpreter group.
(It seems to be ordered by hashcode of 'InterpreterSetting')
When there are many interpreter in same group and this group is first,
user cannot predict what interpreter is showed first.
So I think that interpreter need to be ordered by name.
### What type of PR is it?
[Improvement]
### Todos
* [x] - Modify Code
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3528
### How should this be tested?
* Click 'create new note'
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* No
* Is there breaking changes for older versions?
* No
* Does this needs documentation?
* No
Author: Jaehoon Jeong <jaehoon.je...@woowahan.com>
Closes #3005 from woowahan-jaehoon/ZEPPELIN-3528 and squashes the following
commits:
5cb709ce3 [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in
same interpreter group
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg.
[ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed
behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weand/zeppelin branch-0.8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3202
----
commit 00af514ea29dee5b1df692ea8fd88ea6aad436c2
Author: Jaehoon Jeong <jaehoon.jeong@...>
Date: 2018-06-05T11:39:55Z
[ZEPPELIN-3528] Ordering by interpreter name in same interpreter group
### What is this PR for?
In 'Create new note' diagram, 'Default Interpreter' is ordered by only
interpreter groups.
But interpreter is not ordered in same interpreter group.
(It seems to be ordered by hashcode of 'InterpreterSetting')
When there are many interpreter in same group and this group is first,
user cannot predict what interpreter is showed first.
So I think that interpreter need to be ordered by name.
### What type of PR is it?
[Improvement]
### Todos
* [x] - Modify Code
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3528
### How should this be tested?
* Click 'create new note'
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* No
* Is there breaking changes for older versions?
* No
* Does this needs documentation?
* No
Author: Jaehoon Jeong <jaehoon.je...@woowahan.com>
Closes #3005 from woowahan-jaehoon/ZEPPELIN-3528 and squashes the following
commits:
5cb709ce3 [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in
same interpreter group
----
---
