[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
  
    Hello @felixcheung @Tagar @zjffdu, this is for any further comments and 
suggestions. Here are the features implemented:
    
    1. - The substitution pattern is `{ ... }` as suggested for uniformity with 
Jupyter
    2. - The substitution pattern can be escaped by using `{{ ... }}`, and such 
patterns are translated into `{ ... }` while retaining the original contents of 
`{{ ... }}`
    3. - Substitution patterns inside strings (like `'part-{number}'`) are 
active, and will be substituted. This is also as in the Jupyter feature 
(@felixcheung this is different from our last exchange)
    
    I have expanded the unit-tests to include these cases, and have added error 
checks for a variety of ill-formed patterns. The following screenshots show 
some examples of the feature in use.
    
    
![fig-01](https://user-images.githubusercontent.com/477015/28742890-912ba640-7459-11e7-98dd-8960b2f76a31.png)
    
![fig-02](https://user-images.githubusercontent.com/477015/28742891-912dfc2e-7459-11e7-8a6c-3790de2ef664.png)
    
![fig-03](https://user-images.githubusercontent.com/477015/28742892-9132a9b8-7459-11e7-872d-6c496a98af5c.png)
    
![fig-04](https://user-images.githubusercontent.com/477015/28742893-913749c8-7459-11e7-903b-40b664d1cb2f.png)
    
    Thanks for all your pointers and ideas.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---