GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2360

    Improve about dialgo

    ### What is this PR for?
    
    Improve `about` dialog style. See the attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2574](https://issues.apache.org/jira/browse/ZEPPELIN-2574)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Run Zeppelin and open browser: `localhost:8080`
    3. Click the `About Zeppelin` button
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282057/f4ccec14-3e43-11e7-8f30-aa58f1dbebc0.png)
    
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282052/cc7c879c-3e43-11e7-94e8-887794aba27c.png)
    
    #### After
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282051/c779a284-3e43-11e7-9ee4-3aee2c8d8e17.png)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin improve-about-dialgo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2360
    
----
commit 03619186b6c3518798d51aeb1318c5dfb978e499
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T00:10:05Z

    refactor: Move about related css into navbar.css

commit 5dfc3bd473e3b53ace0b9457e13cbf47d0105154
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T00:31:42Z

    feat: style about dialog

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to