GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2359

    [ZEPPELIN-2575] Improve `rename note` dialog style

    ### What is this PR for?
    
    Improve `rename notebook` dialog style. See the attached screenshots.
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2575](https://issues.apache.org/jira/browse/ZEPPELIN-2575)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Run Zeppelin and open browser: `localhost:8080`
    3. `rename notebook` functionality should work as like before.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282045/8794216c-3e43-11e7-95f7-cce274c77c12.png)
    
    #### After
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26282047/9171c6b2-3e43-11e7-86ee-d861d5f26af9.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin improve-rename-dialog

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2359
    
----
commit ff9721aefd053455e9a7fb863e949d53a7df8734
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T02:32:39Z

    style: Reformat html

commit d310174c11dd24745ff30e448136f373588df921
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T02:39:48Z

    feat: Style rename dialog body

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to