[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

[1ambda]

GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
    
    Highlight active line.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line 
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
    
    ### Screenshots (if appropriate)
    
    
![2460_active_line](https://cloud.githubusercontent.com/assets/4968473/26279598/de38b114-3df2-11e7-9d3a-f0d4f59b8cd1.gif)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
    
----
commit 6424db580c922fac03a42620340f2239d029babe
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

commit 0366948fe750478fc3c4ce946ba0e0383728fa21
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T21:51:03Z

    fix: Show single active line in a note

commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T21:55:18Z

    fix: Use blue-light color for active line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---