GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
    
    Highlight active line.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line 
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
    
    ### Screenshots (if appropriate)
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26278755/268ab126-3ddd-11e7-81c7-088816c7597b.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
    
----
commit cd896079d2e52ced4f9cfc92a1e3a0b0046f60e2
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit 7ceee46f7df29abcc7164a3ccbf2df32095e9824
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to