[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

[1ambda]

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2098
  
    @AhyoungRyu 
    
    1. Hide other buttons when panel is minified
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/24619895/9ac980fc-18d6-11e7-9eec-059e0494c59c.png)
    
    2. Added doc to 
`docs/development/writingzeppelinvisualization_transformation.md`. It looks 
like 
    
    
![2098_docs](https://cloud.githubusercontent.com/assets/4968473/24619937/c1841e46-18d6-11e7-87d0-6350cd4d43c0.gif)
    
    3. Regarding to popup, i think we can skip it because if parameter is 
applied or reset, the chart will change according to the options. The chart 
will remain same only if parameter is not changed at all and user can recognize 
when he/she does't change parameter.
    
    @Leemoonsoo 
    
    4. I added many tests to `advanced-transformation-util.test.js`. It covers 
most cases and many functions. Here is the file.
    
    - 
https://github.com/1ambda/zeppelin/blob/6a0559b18542c60b1211095f7583a71e5fb0c136/zeppelin-web/src/app/tabledata/advanced-transformation-util.test.js
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---