Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2002
BTW @Leemoonsoo , I agree with you that install libfontconfig with shell
script is graceful solution. Unfortunately, in phantomjs package for linux
absent this dependency and we can't build zeppelin at empty linux box without
installation by hand all hidden dependences. I think it would better change
phantomjs to another one.
ÐÑпÑавлено Ñ Ð±ÐµÑпÑоводного ÑÑÑÑойÑÑва
BlackBerry®
-----Original Message-----
From: Lee moon soo <notificati...@github.com>
Date: Sat, 11 Feb 2017 22:40:54
To: apache/zeppelin<zeppe...@noreply.github.com>
Reply-To: apache/zeppelin <re...@reply.github.com>
Cc: Dmytro Shkvyra<dshkv...@gmail.com>; Mention<ment...@noreply.github.com>
Subject: Re: [apache/zeppelin] [ZEPPELIN-1928]: Get a rid of preinstalled
external dependencies (nodejs and npm) for maven build (#2002)
Leemoonsoo commented on this pull request.
> @@ -0,0 +1,2 @@
+#!/bin/bash
+( sudo apt-get install libfontconfig -y || sudo yum install fontconfig -y
) || exit 0;
I'm not sure it's best idea install package on the system without asking
user. Shell we remove this file?
> @@ -120,34 +152,77 @@
</execution>
<execution>
- <id>yarn install</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <configuration>
- <arguments>install --no-lockfile</arguments>
- </configuration>
+ <id>yarn add bower</id>
+ <goals>
+ <goal>yarn</goal>
+ </goals>
+ <configuration>
+ <!--ignore-scripts-->
+ <arguments>add bower --no-lockfile
--no-bin-links</arguments>
we don't need to run
'yarn add bower'
'yarn add karma-phantomjs-launcher'
and we can just run command defined in 'script' field in 'package.json'.
like
'yarn install'
'yarn build'
'yarn test'
we don't want to define the same command in the pom.xml that 'package.json'
already has in 'script' field, such as
'bower install'
'webpack build'
'grunt pre-webpack-dist'
'grunt post-webpack-dist'
'karma test'
I think all changes made in 'executions' section of 'frontend-maven-plugin'
are unnecessary and should be reverted.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/zeppelin/pull/2002#pullrequestreview-21400884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
