[GitHub] zeppelin issue #2002: [ZEPPELIN-1928]: Get a rid of preinstalled external de...

[DmytroShkvyra]

Github user DmytroShkvyra commented on the issue:

    https://github.com/apache/zeppelin/pull/2002
  
    All these packages are required and used in scripts of  package.json. I 
have tested this (run mvn build at clean vbox). And when I tried run
    $ npm install -g yarn
    $ yarn install
    It failed because scripts from package.json couldn't resolve these 
packages. 
    Please note: I in this case I would add also following command:
    $ apt-get install -y nodejs
    Отправлено с беспроводного устройства 
BlackBerry®
    
    -----Original Message-----
    From: Lee moon soo <notificati...@github.com>
    Date: Sat, 11 Feb 2017 00:26:51 
    To: apache/zeppelin<zeppe...@noreply.github.com>
    Reply-To: apache/zeppelin <re...@reply.github.com>
    Cc: Dmytro Shkvyra<dshkv...@gmail.com>; Author<aut...@noreply.github.com>
    Subject: Re: [apache/zeppelin] [ZEPPELIN-1928]: Get a rid of preinstalled
     external dependencies (nodejs and npm) for maven build (#2002)
    
    Leemoonsoo commented on this pull request.
    
    
    
    >  # install required depepdencies and bower packages (only once)
    -$ npm install -g yarn
    -$ yarn install
    +```
    +$ npm install -g yarn bower npm-run-all rimraf grunt webpack karma 
karma-phantomjs-launcher
    
    I'm don't think 'rimraf grunt webpack karma karma-phantomjs-launcher' are 
really a required package installed globally for development. Shell we remove 
them?
    
    Also shell we not use 'npm-run-all' package? 
    After this PR, every existing developer will face error, such as
    
    ```
    $ npm-run-all --parallel dev:server dev:watch 
    sh: npm-run-all: command not found
    error Command failed with exit code 127.
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this 
command.
    ```
    
    and all developer need to read README.md again and install necessary 
package. which is big impact compare to benefit that we can get from 
npm-run-all here. 
    
    What do you think?
    
    -- 
    You are receiving this because you authored the thread.
    Reply to this email directly or view it on GitHub:
    https://github.com/apache/zeppelin/pull/2002#pullrequestreview-21381858



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---