GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1730
[ZEPPELIN-1736] Introduce trash & enable removing folder
### What is this PR for?
This PR introduces the trash! (which is essential, I think ^^;)
I added basic operations of the trash:
#### Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather
than just merging(please see screenshot below!)
### What type of PR is it?
[Feature]
### Future work
Maybe it would be better if notebook view notices that a note is in the
trash.
### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)
### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash
### Screenshots (if appropriate)
## Move, restore, remove a note from the main page
## Move, restore, remove a folder from the main page
## Move, remove a note from the notebook view
## Restore, empty the trash
## Suffix current date if the folder exists in the trash
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1730
----
commit 3b861ee85b93805ec6298f5d17d88f211ef4b8a3
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-06T11:21:38Z
Introduce trash & removing folder
commit e2b2902f4aa4b6456643ec13105928e3afc409b0
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-06T12:54:54Z
Satisfy style check
commit 77d79499f83923f07f8a2451fdb9f2a0e448528d
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-06T12:55:19Z
Remove if note is in the trash from the notebook view
commit 1d597ee152e62e03aa9645284478507821a315ef
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-07T17:12:51Z
Use trash folder id provided by constant service
commit 710c474c022b010ab5ed8038862dbdbbf44f58e3
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-07T17:14:00Z
Change âfor goodâ -> âpermanentlyâ
commit f40e763f33158b82bc4be1cdb08657a248f12baf
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-07T17:15:51Z
Make the order of the trash folder last
commit d5389c016fc018d2c70125429e00836a8d107dd2
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-08T15:28:15Z
Restore a folder without removed date
commit 731a2da29c41b8d3602c105bfa5fab3f7b70ef7d
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-08T15:42:26Z
Define isTrash function on notebook controller
commit b1c459da81d61c131f997150d8644a0f05701c03
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-08T15:59:10Z
Define notebook list button style
commit ab28178a0e818dd1f269969489ec87520ef0e14d
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-08T16:03:39Z
Fix stylecheck issue
commit ecaed2e5740e8cdd5cec1beecee65b9486a8a2dc
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-11T13:52:14Z
Fix white space bug @marchpig addressed
commit 7afdc886ac0113f5123ef032fe6847a3d8d2fd65
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-11T14:07:37Z
Change selenium test codes affected by chaging âremoveNoteâ button to
âmoveToTrashâ
commit 678eb936a6e83a97c7921bf4a5c134ef335e39ae
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-17T12:38:45Z
Change remove permanently icons, remove folder conflict infix
commit 414df5f8ec756e0213ab12b76a649f1e06459a5f
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-22T15:04:59Z
Show trash folder icon at navbar
commit d74bf397a1604ed3e0e27532dfa5666b6b6ab852
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-22T17:18:41Z
Hide rename, clear output buttons
commit 83e2fed7ebe27ac6cc761e8f00e721fe5245d580
Author: Jun Kim <i2r....@gmail.com>
Date: 2016-12-30T11:20:21Z
show trash icon after searching notes
commit 2b5dc93631b80fcdb5ba5e54a743cef9dc3c245f
Author: Jun Kim <i2r....@gmail.com>
Date: 2017-01-01T07:29:13Z
copy notesList one time.
_.map() is immutable
commit 6bf0a7011c6e55ee6ebd73d13d7ccb6b2dabdee2
Author: Jun Kim <i2r....@gmail.com>
Date: 2017-01-01T07:30:34Z
Fix factory/noteList test error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
