[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

Sat, 17 Dec 2016 05:34:27 -0800 

GitHub user tae-jun reopened a pull request:

    https://github.com/apache/zeppelin/pull/1730

    [ZEPPELIN-1736] Introduce trash & enable removing folder

    ### What is this PR for?
    
![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
    This PR introduces the trash! (which is essential, I think ^^;)
    
    I added basic operations of the trash:
    #### Added operations of trash
    * `Move` a folder to the trash
    * `Move` a note to the trash
    * `Restore` a folder
    * `Restore` a note
    * `Remove` a folder in the trash for good
    * `Remove` a note in the trash for good
    * `Empty` the trash
    * `Restore all` in the trash
    * `Move` a note to the trash from the notebook view
    * `Remove` a note to the trash for good from the notebook view
    * If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)
    
    
    ### What type of PR is it?
    [Feature]
    
    ### Future work
    Maybe it would be better if notebook view notices that a note is in the 
trash.
    
    ### What is the Jira issue?
    [ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)
    
    ### How should this be tested?
    * Build this PR
    * Move some folders or notes to the trash
    * Restore them
    * Empty the trash
    * Restore all notes in the trash
    * Remove folders or notes in the trash
    * Remove a folder which has the same folder name in the trash
    
    ### Screenshots (if appropriate)
    ## Move, restore, remove a note from the main page
    
![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)
    
    ## Move, restore, remove a folder from the main page
    
![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)
    
    ## Move, remove a note from the notebook view
    
![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)
    
    ## Restore, empty the trash
    
![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)
    
    ## Suffix current date if the folder exists in the trash
    
![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1730
    
----
commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim <[email protected]>
Date:   2016-12-06T11:21:38Z

    Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim <[email protected]>
Date:   2016-12-06T12:54:54Z

    Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim <[email protected]>
Date:   2016-12-06T12:55:19Z

    Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:12:51Z

    Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:14:00Z

    Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim <[email protected]>
Date:   2016-12-07T17:15:51Z

    Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:28:15Z

    Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:42:26Z

    Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim <[email protected]>
Date:   2016-12-08T15:59:10Z

    Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim <[email protected]>
Date:   2016-12-08T16:03:39Z

    Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim <[email protected]>
Date:   2016-12-11T13:52:14Z

    Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim <[email protected]>
Date:   2016-12-11T14:07:37Z

    Change selenium test codes affected by chaging ‘removeNote’ button to 
‘moveToTrash’

commit 4d074b4a831c97b65746e8205681aa6d44ae4683
Author: Jun Kim <[email protected]>
Date:   2016-12-17T12:38:45Z

    Change remove permanently icons, remove folder conflict infix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to