Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@AhyoungRyu Always thanks for your nice review ð
Yes, it's intended. A time stamp is generated only if a `folder` already
exists in the trash. But it's not generated when moving a `note` to the trash.
I made this feature because of a **use case** like this:
### A use case needs time stamp
1. A user moves "NoteDirA" folder to the trash
2. And the user create a folder which has the same name ("NoteDirA")
3. After a month from then, the user forgot the existence of the folder
already exists in the trash, and moves the folder to the trash which created
later
4. But it was a mistake and the user wants to restore the folder created
later
### Necessity of the time stamp for the use case above
**If there is no time stamp:**
The folder created later will be merged into old one and the folder
"NoteDirA" will be messy.
#### If there is a time stamp:
The folder created later will be moved to the trash with a time stamp
postfix. There will be two folders which are "NoteDirA" (old one) and "NoteDirA
removed at 2016-12-14 xx:xx:xx" (new one). In this case, the user can restore
the folder successfully.
This is why I added time stamp! :-) Please tell me if there is any other
idea.
### Remove permanently icon candidates (?)
I agree with you so I searched Font Awesome and found some candidates for
the icon. I think not only `empty trash` but also `Remove note permanently` and
`Remove folder permanently` should be replaced together.
The icons above are the candidates I found, but please let me know if you
have a better one!
Which icon do you prefer? ð
Thanks for the review again ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
