On 22 March 2016 at 06:14, Jim Jagielski <j...@jagunet.com> wrote: > Well, it looks like the format has been changing... so I > can see concerns. > > But really, I'm not sure why it needs to be so > "standardized" esp when it's mucking around with > stuff it has no reason to. It's adding a line, so > I don't see the reason why it has to "recreate" the > file in the 1st place. Either it finds where a new > proxy needs to go and adds it there, or find the > line that needs to be updated, and modified *that* > line, or it finds the line it needs to delete > and trashes it. > > If a tool is updating a file which is also mostly edited > by humans, it should be pretty lax about enforcing > a "format" imo. If it doesn't need to mess with > a line, it should leave it alone or output it > exactly as it was read...
Agree - I took the approach of just adding anything missing, and retaining the existing lines of text: https://github.com/apache/whimsy/pull/7 Cheers, Brett
