> I think this is generally ok. I suggest elaborating a bit more in the text of > the RFC that the preprocessors apply to the target kind, and that for all > architectures, the code specific to each architecture would need to be > handled as a part of the common preprocessor. The use of names like > `MyArchPreprocessor` and `MyKeysPreprocessor` suggests that there can be > multiple specialized preprocessors. I'd replace them with `CArchPreprocessor` > and `CKeysPreprocessor`, since they both show up in the `c` target kind.
Ideally I'd like to convey the ability to attach it to any `TargetKind` rather than implying it's designed for a specific `TargetKind`, maybe `CPUArchPreprocessor` which can be re-used between `llvm` and `c` which calls out to `AArch64ArchPreprocessor` or `x86ArchPreprocessor`?. You can use a single level pre-processor if that's appropriate (i.e. for `rocm`), which would just be `ROCmArchPreprocessor`. I can outline both cases if that'd help? -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1129796641 You are receiving this because you are subscribed to this thread. Message ID: <apache/tvm-rfcs/pull/71/c1129796...@github.com>
