+1 on deprecating cpp-api and removing the examples. On Thu, Aug 17, 2023 at 10:59 AM Leif Hedstrom <zw...@apache.org> wrote:
> > > > On Aug 17, 2023, at 07:11, Walt Karas <wka...@yahooinc.com.invalid> > wrote: > > > > Does anyone have objections to the general plan to deprecate the C++ > API? > > I’m ok deprecating it :). > > > > Since include/tscpp/api/Cleanup.h is distinct from the rest to the C++ > API > > (designed to support the C-style API rather than enacapsulate it), I > > propose moving it to include/ts and not deprecating it: > > https://github.com/apache/trafficserver/pull/10231 > > > I’ve been thinking about this. I wonder if we should have “modular” > include files rather than one big monster included file going forward? Like > how libswoc and most other libraries does :). > > We can still add / modify to the existing ts.h “module” as needed (its > implementation is in InkAPI.cc). But this is why input the new metrics APIs > in include/api/Metrics.h and src-api/Metrics.cc. > > Thoughts? Maybe a discussion to have on a different thread? > > — Leif > > > >> On Wed, Aug 16, 2023 at 6:18 PM Walt Karas <wka...@yahooinc.com> wrote: > >> > >> +1 > >> > >>> On Wed, Aug 16, 2023 at 2:39 PM Chris McFarlen <ch...@mcfarlen.us> > wrote: > >>> > >>> The cpp plugin API is being deprecated for 10.0 (tscpp/api/*). I'd like > >>> to just remove the examples immediately for 10.0 since we don't need > >>> examples for a deprecated API. Removing them now will also create less > work > >>> for the CMake build. Please vote and/or express any concerns about > this. > >>> > >>> Thanks, > >>> Chris > >>> > >>> Sent with [Proton Mail]( > >>> > https://urldefense.com/v3/__https://proton.me/__;!!Op6eflyXZCqGR5I!F7fmmyOYggHH3sfe66Yv6v1z3dq9Jukk6YGb1uHadpgER3L_rFhZKcsbUlefoe1YmRic6ffK6wzuuOSh$ > >>> ) secure email. > >> > >> > > -- "Come to Me, all who are weary and heavy-laden, and I will give you rest. Take My yoke upon you and learn from Me, for I am gentle and humble in heart, and you will find rest for your souls. For My yoke is easy and My burden is light." ~ Matthew 11:28-30
