I've issued a pull request for the implementation of this: https://github.com/apache/trafficserver/pull/3145
On Thu, Feb 1, 2018 at 12:49 PM, Leif Hedstrom <zw...@apache.org> wrote: > > >> On Feb 1, 2018, at 9:35 AM, Alan Carroll <solidwallofc...@oath.com.INVALID> >> wrote: >> >> That's a good suggestion, although shouldn't it be >> >> TSReturnCode TSRemapFromUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TSMLoc* obj); >> >> That is the TSMLoc should be an out parameter, not an in. In that case I'd >> drop the ...StringGet() and use the generic TSUrlStringGet() if a string is >> needed. > > > I’m definitely not convinced we need those additional StringGet() APIs, when > the existing one would definitely work. As for the unused marshaling buffer, > we can look into that for 8.0.0, and decide if it’s never needed, and clean > that up and fix the APIs accordingly. I’d much rather prefer that, that > introduce new, duplicated functionality APIs. > > — Leif >
