> On Jun 21, 2016, at 2:06 PM, Phil Sorber <sor...@apache.org> wrote: > > On Tue, Jun 21, 2016 at 2:31 PM James Peach <jpe...@apache.org> wrote: > >> >>> On Jun 21, 2016, at 12:19 PM, Phil Sorber <sor...@apache.org> wrote: >>> >>> So I was +1 on this, but now looking at the full diff I am -0. I wanted >> to >>> get others take on this. It aligns *all* assignments not just declaration >>> ones. >>> >>> For example: >>> - c->vio.op = VIO::READ; >>> + c->vio.op = VIO::READ; >>> c->base_stat = cache_lookup_active_stat; >>> CACHE_INCREMENT_DYN_STAT(c->base_stat + CACHE_STAT_ACTIVE); >>> c->first_key = c->key = *key; >>> - c->frag_type = type; >>> - c->f.lookup = 1; >>> - c->vol = vol; >>> - c->last_collision = NULL; >>> + c->frag_type = type; >>> + c->f.lookup = 1; >>> + c->vol = vol; >>> + c->last_collision = NULL; >>> >>> This seems weird and distracting to me. It groups ones on consecutive >> lines >>> too. So you might have different spacing within one body of code because >>> there are other non-assignment lines in between. It also doesn't appear >> to >>> align things like +=. >>> >>> - cstate->cache_vc = (TSVConn)edata; >>> - cstate->write_vio = TSVConnWrite(cstate->net_vc, contp, >>> cstate->resp_reader, INT64_MAX); >>> + cstate->cache_vc = (TSVConn)edata; >>> + cstate->write_vio = TSVConnWrite(cstate->net_vc, contp, >>> cstate->resp_reader, INT64_MAX); >>> cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, error, >>> sizeof(error) - 1); >>> >>> If everyone is still onboard then lets stick with it, but just wanted to >>> talk this out. >> >> Yeh I agree that there are ugly cases, but on balance I think this made >> the formatting cleaner. With some judicious blank lines to reset the >> indentation and application of clang-format-off, can we improve the >> distracting cases you found? >> > > I think the distracting cases I found were due to reset indentation. > Ignoring the augmented assignment won't be fixed either. > > I think if everyone is on board, I can make do. Just wanted to have this > conversation.
Hmmm, I think I hate this now… It really makes shit looks super ugly in a bunch of cases, to the point where the ugliness outweighs the goodness. Can / should we just undo this, and re-run clang-format again? I would hate to revert it, because that will cause chaos I think. — Leif
