On Sat, Aug 3, 2013 at 1:12 AM, James Peach <jpe...@apache.org> wrote:
> On Aug 2, 2013, at 9:59 AM, Yunkai Zhang <yunkai...@gmail.com> wrote: > > > Hi james, > > > > Why I use TS-1006 ticket is that I hope users can easy to find all > > reclaimable-freelist patch by "TS-1006" key word when they search git > log. > > > > But I'm sorry if I break some jira rules. > > In this case, I think a separate ticket is better because TS-1006 is > closed and has a fix version of 3.3.4. This additional change will not be > in 3.3.4, so tracking the history through Jira gets a little confusing. > It's an independent change that could be backported somewhere separately > from the original TS-1006 commits. > got it, agree with you:) > > There's no strict rules here and we can reasonably have different opinions > on how things are easier to track :) > > > > > > > On Sat, Aug 3, 2013 at 12:24 AM, James Peach <jpe...@apache.org> wrote: > > > >> On Aug 2, 2013, at 9:07 AM, yun...@apache.org wrote: > >> > >>> Updated Branches: > >>> refs/heads/master 5b0053ed3 -> cdbfe1d6d > >>> > >>> > >>> TS-1006: adjust some reclaimable-freelist's default configuration > >> > >> This probably should have used a new Jira ticket. > >> > >>> > >>> 1) Adjust "enable_reclaim" to "1" as default in > >>> records.config.default.in file. > >>> > >>> 2) Adjust "max_overage" to "3" in code, so that it keeps the same value > >>> with records.config.default.in. And most important, this value seems > >>> work well in our product environment. > >>> > >>> Signed-off-by: Yunkai Zhang <qiushu....@taobao.com> > >>> > >>> > >>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > >>> Commit: > >> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/cdbfe1d6 > >>> Tree: > http://git-wip-us.apache.org/repos/asf/trafficserver/tree/cdbfe1d6 > >>> Diff: > http://git-wip-us.apache.org/repos/asf/trafficserver/diff/cdbfe1d6 > >>> > >>> Branch: refs/heads/master > >>> Commit: cdbfe1d6d6c43241d773a32e3bbdddddd0ca1d9b > >>> Parents: 5b0053e > >>> Author: Yunkai Zhang <qiushu....@taobao.com> > >>> Authored: Fri Aug 2 23:27:52 2013 +0800 > >>> Committer: Yunkai Zhang <qiushu....@taobao.com> > >>> Committed: Sat Aug 3 00:06:54 2013 +0800 > >>> > >>> ---------------------------------------------------------------------- > >>> mgmt/RecordsConfig.cc | 2 +- > >>> proxy/config/records.config.default.in | 4 ++-- > >>> 2 files changed, 3 insertions(+), 3 deletions(-) > >>> ---------------------------------------------------------------------- > >>> > >>> > >>> > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cdbfe1d6/mgmt/RecordsConfig.cc > >>> ---------------------------------------------------------------------- > >>> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc > >>> index b5b9972..0cf67a8 100644 > >>> --- a/mgmt/RecordsConfig.cc > >>> +++ b/mgmt/RecordsConfig.cc > >>> @@ -1837,7 +1837,7 @@ RecordElement RecordsConfig[] = { > >>> //############ > >>> {RECT_CONFIG, "proxy.config.allocator.debug_filter", RECD_INT, "0", > >> RECU_NULL, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL} > >>> , > >>> - {RECT_CONFIG, "proxy.config.allocator.max_overage", RECD_INT, "10", > >> RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} > >>> + {RECT_CONFIG, "proxy.config.allocator.max_overage", RECD_INT, "3", > >> RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} > >>> , > >>> {RECT_CONFIG, "proxy.config.allocator.enable_reclaim", RECD_INT, "1", > >> RECU_NULL, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL} > >>> , > >>> > >>> > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cdbfe1d6/proxy/config/records.config.default.in > >>> ---------------------------------------------------------------------- > >>> diff --git a/proxy/config/records.config.default.in b/proxy/config/ > >> records.config.default.in > >>> index b757418..b3b7a09 100644 > >>> --- a/proxy/config/records.config.default.in > >>> +++ b/proxy/config/records.config.default.in > >>> @@ -616,8 +616,8 @@ CONFIG proxy.config.diags.show_location INT 0 > >>> # bit 0: reclaim memory in ink_freelist_new > >>> # bit 1: allocate memory from partial-free Chunks(if exist) or OS > >>> CONFIG proxy.config.allocator.debug_filter INT 0 > >>> - # The value of enable_reclaim should be 0 or 1. Default 0, reclaim > >> disabled. > >>> -CONFIG proxy.config.allocator.enable_reclaim INT 0 > >>> + # The value of enable_reclaim should be 0 or 1. Default 1, reclaim > >> enabled. > >>> +CONFIG proxy.config.allocator.enable_reclaim INT 1 > >>> # The value of reclaim_factor should be in 0.0 ~ 1.0, allocator use it > >> to > >>> # calculate average value of idle memory in InkFreeList, which will > >> determine > >>> # when to reclaim memory. The larger the value, the faster the > >> reclaiming. > >>> > >> > >> > > > > > > -- > > Yunkai Zhang > > Work at Taobao > > -- Yunkai Zhang Work at Taobao
