On Aug 1, 2013, at 9:36 PM, Leif Hedstrom <zw...@apache.org> wrote: > On Aug 2, 2013, at 12:33 AM, Igor Galić <i.ga...@brainsware.org> wrote: > >> >>> + "proxy.config.http.request_header_max_size", >>> + "proxy.config.http.response_header_max_size" >> >> why not close this up with a ',' ? > > Here it *might* make sense, but I personally don't care for it much.
In the olden days compilers would puke on that. > >>> + TS_CONFIG_HTTP_RESPONSE_HEADER_MAX_SIZE, >>> + TS_CONFIG_LAST_ENTRY >> >> why not close this up with a ',' ? > > Here we should absolutely not add a trailing (extraneous) ",". There's a > reason for this, TS_CONFIG_LAST_ENTRY is a sentinel, it must always be the > last. Having a trailing "," would potentially invite people to append to it, > which simply won't work. :) > > > Cheers and thanks for the reviews, as usual. We need more Igor's. > > -- leif >
