On Aug 1, 2013, at 11:00 PM, James Peach <jpe...@apache.org> wrote:
> On Aug 1, 2013, at 1:46 PM, zw...@apache.org wrote:
> 
>> Updated Branches:
>> refs/heads/master cecc082d4 -> 7485e0b5f
>> 
>> 
>> TS-1255 Add Req/Resp max header size to be overridable
> 
> Would it be more robust to use a lookup table for the overridable value types?
> 
> static const
> struct {
>    OverridableDataType o_type;
>    size_t o_offset;
> } overridable[] = {
> 
>  /* TS_CONFIG_URL_REMAP_PRISTINE_HOST_HDR */
>  { OVERRIDABLE_TYPE_BYTE, offsetof(OverridableHttpConfigParams, 
> maintain_pristine_host_hdr},


Seems reasonable. File a bug, and fix it after v3.4 ?

-- leif

Reply via email to